Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contribs/gnomd #1256

Merged
merged 6 commits into from
Nov 8, 2023
Merged

feat: add contribs/gnomd #1256

merged 6 commits into from
Nov 8, 2023

Conversation

moul
Copy link
Member

@moul moul commented Oct 19, 2023

This PR adds a contribs/gnomd binary.
Please review PR #1001 for the maketx run.

Additionally, this PR introduces the contribs/ folder. It allows the creation of contribs/gno* Go packages, Python/Rust/Shell/… scripts. This approach keeps the main gno, gnokey, and gnoland simple while adhering to the Unix philosophy and incorporating several specific gno commands.

CleanShot 2023-10-19 at 09 17 40@2x

@moul moul self-assigned this Oct 19, 2023
@moul moul changed the title feat: add contribs/gnorender feat: add gnorender (contribs) Oct 19, 2023
@moul moul marked this pull request as ready for review October 19, 2023 13:51
@moul moul requested a review from a team as a code owner October 19, 2023 13:51
@moul moul changed the title feat: add gnorender (contribs) feat: add gno-render (contribs) Oct 19, 2023
moul added 2 commits October 19, 2023 17:59
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89428c5) 47.84% compared to head (742fcc9) 55.89%.
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
+ Coverage   47.84%   55.89%   +8.05%     
==========================================
  Files         369      421      +52     
  Lines       62764    66727    +3963     
==========================================
+ Hits        30028    37296    +7268     
+ Misses      30308    26528    -3780     
- Partials     2428     2903     +475     

see 135 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul changed the title feat: add gno-render (contribs) feat: add gnomd(contribs) Oct 19, 2023
@moul moul changed the title feat: add gnomd(contribs) feat: add contribs/gnomd Oct 20, 2023
@moul moul mentioned this pull request Oct 25, 2023
7 tasks
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

contribs/gnomd/main.go Outdated Show resolved Hide resolved
@moul moul merged commit 11f4359 into master Nov 8, 2023
179 checks passed
@moul moul deleted the dev/moul/gnorender branch November 8, 2023 08:15
thehowl pushed a commit that referenced this pull request Nov 9, 2023
## Done

- add a `contribs/gnokeykc` wrapper (adding keychain support).
- make `tm2/commands.IO` an interface instead of a struct.

## Usage

```console
$ gnokeykc kc set
Enter password.
Successfully added password for key.
$ gnokeykc maketx send --send 1ugnot --to g1fsu3z335h5qngf7t3lmakvpmpwg9ae76tqwh7c --chainid test3 --remote test3.gno.land:36657 --gas-fee "1000000ugnot" --gas-wanted "2000000" --broadcast moul


OK!
GAS WANTED: 2000000
GAS USED:   47072
```

## Links

- [x] Depends on #1256 (for contribs/' Makefile & CI)

---------

Signed-off-by: moul <[email protected]>
moul added a commit to moul/gno that referenced this pull request Nov 14, 2023
This PR adds a `contribs/gnomd` binary.
Please review PR gnolang#1001 for the `maketx run`. 

Additionally, this PR introduces the `contribs/` folder. It allows the
creation of `contribs/gno*` Go packages, Python/Rust/Shell/… scripts.
This approach keeps the main `gno`, `gnokey`, and `gnoland` simple while
adhering to the Unix philosophy and incorporating several specific gno
commands.

![CleanShot 2023-10-19 at 09 17
40@2x](https://github.com/gnolang/gno/assets/94029/9b92bf18-f923-4f70-aea7-a88f185f2342)

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: Morgan <[email protected]>
moul added a commit to moul/gno that referenced this pull request Nov 14, 2023
## Done

- add a `contribs/gnokeykc` wrapper (adding keychain support).
- make `tm2/commands.IO` an interface instead of a struct.

## Usage

```console
$ gnokeykc kc set
Enter password.
Successfully added password for key.
$ gnokeykc maketx send --send 1ugnot --to g1fsu3z335h5qngf7t3lmakvpmpwg9ae76tqwh7c --chainid test3 --remote test3.gno.land:36657 --gas-fee "1000000ugnot" --gas-wanted "2000000" --broadcast moul


OK!
GAS WANTED: 2000000
GAS USED:   47072
```

## Links

- [x] Depends on gnolang#1256 (for contribs/' Makefile & CI)

---------

Signed-off-by: moul <[email protected]>
@jefft0 jefft0 requested review from jefft0 and removed request for jefft0 November 19, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Status: 🔵 Not Needed for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants